suneet-s commented on code in PR #16510: URL: https://github.com/apache/druid/pull/16510#discussion_r1630003561
########## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/execution/ExecutionConfig.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.k8s.overlord.execution; + +import com.fasterxml.jackson.annotation.JsonSubTypes; +import com.fasterxml.jackson.annotation.JsonTypeInfo; + +/** + * Represents the configuration for task execution within a Kubernetes environment. + * This interface allows for dynamic configuration of task execution strategies based + * on specified behavior strategies. + */ +@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type", defaultImpl = DefaultExecutionConfig.class) +@JsonSubTypes(value = { + @JsonSubTypes.Type(name = "default", value = DefaultExecutionConfig.class) +}) +public interface ExecutionConfig +{ + String CONFIG_KEY = "k8s.taskrunner.config"; Review Comment: YongGang and I discussed this offline, and I better understand the intent of this config object. It seems like this is trying to provide similar functionality as `KubernetesTaskRunnerConfig` but via the dynamic config. It makes sense to have an encompassing dynamic config object for this extension. Some suggested names for this that better indicate it's purpose `KubernetesTaskRunnerDynamicConfig` `KubernetesPeonDynamicConfig` `KubernetesTaskExecutionConfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
