AmatyaAvadhanula opened a new pull request, #16623: URL: https://github.com/apache/druid/pull/16623
https://github.com/apache/druid/pull/16380/ utilized an existing metadata query to fetch unused segments for a given datasource, interval and version but this appeared to take a long time despite the indexes, and could have potential overlord stability implications. This PR optimizes the query by using an equality check on the interval start and end as it is a special case for segment allocation, instead of using the OVERLAPS or CONTAINS match modes. On a cluster with 1.8M unused segments for a given datasource, the query which relied on the existing method took over 30s on average, while the new query takes less than a second. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
