AmatyaAvadhanula commented on code in PR #16623:
URL: https://github.com/apache/druid/pull/16623#discussion_r1644166511


##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -249,6 +249,47 @@ public List<Pair<DataSegment, String>> 
retrieveUsedSegmentsAndCreatedDates(Strin
     );
   }
 
+  @Override
+  public List<DataSegment> retrieveUnusedSegmentsForExactIntervalAndVersion(
+      String dataSource,
+      Interval interval,
+      String version
+  )
+  {
+    StringBuilder sb = new StringBuilder();
+    sb.append(StringUtils.format("SELECT payload FROM %s", 
dbTables.getSegmentsTable()));

Review Comment:
   segment_111 is less than segment_2 lexicographically. I don't think this 
would work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to