kfaraz commented on code in PR #16623:
URL: https://github.com/apache/druid/pull/16623#discussion_r1644243542
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -249,6 +249,46 @@ public List<Pair<DataSegment, String>>
retrieveUsedSegmentsAndCreatedDates(Strin
);
}
+ public List<DataSegment> retrieveUnusedSegmentsForExactIntervalAndVersion(
+ String dataSource,
+ Interval interval,
+ String version
+ )
+ {
+ final String sql = "SELECT payload FROM %1$s"
+ + " WHERE used = :used AND dataSource = :dataSource AND
version = :version"
Review Comment:
```suggestion
+ " WHERE used = :used"
+ " AND dataSource = :dataSource"
+ " AND version = :version"
```
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -249,6 +249,46 @@ public List<Pair<DataSegment, String>>
retrieveUsedSegmentsAndCreatedDates(Strin
);
}
+ public List<DataSegment> retrieveUnusedSegmentsForExactIntervalAndVersion(
+ String dataSource,
+ Interval interval,
+ String version
+ )
+ {
+ final String sql = "SELECT payload FROM %1$s"
+ + " WHERE used = :used AND dataSource = :dataSource AND
version = :version"
+ + " AND start = :start AND %2$send%2$s = :end";
+
+ final List<DataSegment> matchingSegments = connector.inReadOnlyTransaction(
+ (handle, status) -> {
+ final Query<Map<String, Object>> query = handle
+ .createQuery(StringUtils.format(
+ sql,
+ dbTables.getSegmentsTable(),
+ connector.getQuoteString()
+ ))
+ .setFetchSize(connector.getStreamingFetchSize())
+ .bind("used", false)
+ .bind("dataSource", dataSource)
+ .bind("version", version)
+ .bind("start", interval.getStart().toString())
+ .bind("end", interval.getEnd().toString());
+
+ try (final ResultIterator<DataSegment> iterator =
+ query.map(
+ (index, r, ctx) -> JacksonUtils.readValue(jsonMapper,
r.getBytes(1), DataSegment.class)
+ ).iterator()
+ ) {
+ return ImmutableList.copyOf(iterator);
+ }
+ }
+ );
+
+ log.info("Found [%,d] unused segments for datasource[%s] for interval[%s]
and version[%s].",
Review Comment:
```suggestion
log.debug("Found [%,d] unused segments for datasource[%s], interval[%s],
version[%s].",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
