LakshSingla commented on code in PR #16620:
URL: https://github.com/apache/druid/pull/16620#discussion_r1663897732
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -1726,6 +1791,12 @@ public Object2IntMap<Object[]> getReverseDictionary()
{
return reverseDictionary;
}
+
+ @Override
+ public Class<?> getClazz()
+ {
+ return Object.class;
Review Comment:
It shouldn't matter in practice since while reading from the serialized
state, the mapper would have enough context if it's an array or not. The type
information would get lost since we assign it to an `Object` at the end.
It's cleaner to have type information, but I kept it to preserve the
original behavior for the arrays - reading it without a type and the mapper
would deserialize to generic java objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
