LakshSingla commented on code in PR #16620:
URL: https://github.com/apache/druid/pull/16620#discussion_r1663903298
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -1819,6 +1896,12 @@ public BufferComparator getBufferComparator()
{
return bufferComparator;
}
+
+ @Override
+ public Class<?> getClazz()
+ {
+ return Object.class;
Review Comment:
Similar explanation as to why I left it as Object.class to preserve existing
behavior rather than being clearer and mentioning String.class.
I doubt we'd run into regressions with the latter, but I was being overtly
cautious.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
