kfaraz opened a new pull request, #16691:
URL: https://github.com/apache/druid/pull/16691

   ### Changes
   
   - Add `LoadingRateTracker` which computes a moving average load rate based on
   the last few GBs of successful segment loads.
   - Emit metric `segment/loading/rateKbps` from the Coordinator. In the 
future, we may
   also consider emitting this metric from the historicals themselves.
   - Add `expectedLoadTimeMillis` to response of API 
`/druid/coordinator/v1/loadQueue?simple`
   
   ### Testing done
   - Added new unit tests
   - Performed testing on local cluster with ~1M segments
   
   ### Pending
   
   Documentation changes for API and new metric.
   
   ### Future work
   
   The `expectedLoadTimeMillis` can be used to show expected time on the 
web-console.
   
   __This PR does not include web-console changes and the screenshot below is 
only for reference.__
   
   <img width="944" alt="load_time" 
src="https://github.com/apache/druid/assets/18635897/e3f4716b-c74e-4161-bfc1-15d1835a92e2";>
   
   ---
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to