kfaraz commented on PR #16691: URL: https://github.com/apache/druid/pull/16691#issuecomment-2214488639
@abhishekrb19 , just realized that there is actually an error in the logic to compute the time taken to load. 😛 Imagine the following scenario: - t0: Coordinator wants to load 4 segments on Historical. - t0: Coordinator sends request to Historical to load the 4 segments. - t1: Historical sends back a response as soon as any one segment finishes loading. - t1: Coordinator measures time spent in the request = `(t1 - t0)`. - t2: Coordinator sends next request to historical. This request again contains the remaining 3 segments which the Coordinator thinks are not loaded yet. - t3: Historical sends back a response saying that the remaining 3 segments have been loaded. - t3: Coordinator measures time spent in second request = `(t3 - t2)` So total time measured by Coordinator = `(t3 - t2) + (t1 - t0)` But actual total time taken by Historical to load all segments = `(t3 - t0)` I am trying to figure out how to fix this. Will update once I have a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
