abhishekrb19 commented on PR #16691: URL: https://github.com/apache/druid/pull/16691#issuecomment-2223376124
@kfaraz, thanks for the updates, I haven't looked into the latest changes yet. But a quick question based on the comments: >Reverted to simpler logic that works well for single threads. Does this mean that the simpler logic now only accounts for the default case of a single loading thread (`druid.segmentCache.numLoadingThreads`)? That seems reasonable for now if we don't want the added complexity, but what is reported when there are multiple loading threads? Instead of reporting potentially incorrect values, I think we can skip reporting the metric and including `expectedLoadTimeMillis` in the API until we have proper support for accounting for multiple threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
