abhishekrb19 commented on code in PR #16713:
URL: https://github.com/apache/druid/pull/16713#discussion_r1671612135
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java:
##########
@@ -234,12 +234,13 @@ private boolean cancelTaskIfGranularityChanged(
Granularity configuredSegmentGranularity =
dataSourceCompactionConfig.getGranularitySpec()
.getSegmentGranularity();
Granularity taskSegmentGranularity =
compactionTaskQuery.getGranularitySpec().getSegmentGranularity();
Review Comment:
The fix makes sense. It seems that the members and getters in
`UserCompactionTaskGranularityConfig` are missing `@Nullable` annotations.
Could we also update those?
Also, for this bug fix, it'll be good to update an existing test for in
`CompactSegmentsTest` or another relevant test to pass null values to the
compaction task query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
