kfaraz commented on code in PR #16713:
URL: https://github.com/apache/druid/pull/16713#discussion_r1671618431


##########
server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java:
##########
@@ -234,12 +234,13 @@ private boolean cancelTaskIfGranularityChanged(
     Granularity configuredSegmentGranularity = 
dataSourceCompactionConfig.getGranularitySpec()
                                                                          
.getSegmentGranularity();
     Granularity taskSegmentGranularity = 
compactionTaskQuery.getGranularitySpec().getSegmentGranularity();

Review Comment:
   Some of the `@Nullable` annotations are being added in another PR #16291 , 
so I skipped them here.
   Okay if we add the tests separately? I want to merge this PR and not wait 
for another CI build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to