Akshat-Jain commented on code in PR #16804:
URL: https://github.com/apache/druid/pull/16804#discussion_r1696309793
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -309,12 +308,16 @@ private ShuffleSpec
findShuffleSpecForNextWindow(List<OperatorFactory> operatorF
}
}
- if (partition == null || partition.getPartitionColumns().isEmpty()) {
+ if (partition == null) {
Review Comment:
We don't have any tests currently for most of the window function specific
files. I plan on adding them post the major refactoring work is done. We do
have drill tests where I try to add any new case I stumble upon.
But for now, `partition == null` condition is correct. We do have drill
tests to verify that flow.
`partition == null` condition is different than
`partition.getPartitionColumns().isEmpty()`.
`partition == null` indicates that the group of operators doesn't have any
NaivePartitioningOperatorFactory, whereas the latter one indicates that we need
to bring all data together for computing an empty over clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
