Akshat-Jain commented on code in PR #16804:
URL: https://github.com/apache/druid/pull/16804#discussion_r1696331277
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ScanQueryKit.java:
##########
@@ -178,6 +183,11 @@ public QueryDefinition makeQueryDefinition(
}
}
+ // If window has an empty over, we want a single worker to process entire
data for window function evaluation.
+ if (windowHasEmptyOver) {
+ scanShuffleSpec = MixShuffleSpec.instance();
Review Comment:
I think so. WindowOperatorQueryKit would be adding a sorting operator anyway
(if it needs to), so we just need a MixShuffleSpec to bring all the data into a
single worker for window function evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
