gianm commented on code in PR #16849:
URL: https://github.com/apache/druid/pull/16849#discussion_r1706160627
##########
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java:
##########
@@ -887,19 +942,23 @@
* Currently called to initialize IncrementalIndex dimension order during
index creation
* Index dimension ordering could be changed to initialize from
DimensionsSpec after resolution of
* https://github.com/apache/druid/issues/2011
+ *
+ * @param oldDimensionOrder dimension order to initialize
+ * @param oldColumnFormats formats for the dimensions
*/
public void loadDimensionIterable(
Iterable<String> oldDimensionOrder,
- Map<String, ColumnFormat> oldColumnCapabilities
+ Map<String, ColumnFormat> oldColumnFormats
)
{
synchronized (dimensionDescs) {
- if (!dimensionDescs.isEmpty()) {
- throw new ISE("Cannot load dimension order when existing order[%s] is
not empty.", dimensionDescs.keySet());
+ if (size() != 0) {
+ throw new ISE("Cannot load dimension order when existing index is not
empty.", dimensionDescs.keySet());
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
