gianm commented on code in PR #16849:
URL: https://github.com/apache/druid/pull/16849#discussion_r1708051126
##########
processing/src/main/java/org/apache/druid/segment/incremental/OnheapIncrementalIndex.java:
##########
@@ -777,11 +790,18 @@ public Iterator<IncrementalIndexRow> iterator(boolean
descending)
@Override
public Iterable<IncrementalIndexRow> timeRangeIterable(boolean descending,
long timeStart, long timeEnd)
{
- IncrementalIndexRow start = new IncrementalIndexRow(timeStart, new
Object[]{}, dimensionDescsList);
- IncrementalIndexRow end = new IncrementalIndexRow(timeEnd, new
Object[]{}, dimensionDescsList);
- ConcurrentNavigableMap<IncrementalIndexRow, IncrementalIndexRow> subMap
= facts.subMap(start, end);
- ConcurrentMap<IncrementalIndexRow, IncrementalIndexRow> rangeMap =
descending ? subMap.descendingMap() : subMap;
- return rangeMap.keySet();
+ if (timeOrdered) {
+ IncrementalIndexRow start = new IncrementalIndexRow(timeStart, new
Object[]{}, dimensionDescsList);
+ IncrementalIndexRow end = new IncrementalIndexRow(timeEnd, new
Object[]{}, dimensionDescsList);
+ ConcurrentNavigableMap<IncrementalIndexRow, IncrementalIndexRow>
subMap = facts.subMap(start, end);
+ ConcurrentMap<IncrementalIndexRow, IncrementalIndexRow> rangeMap =
descending ? subMap.descendingMap() : subMap;
+ return rangeMap.keySet();
+ } else {
+ return Iterables.filter(
Review Comment:
I think it's also used for `intervals` filtering even for non-granular
cursors. It seems like it'd be useful for that at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
