gianm commented on code in PR #16849:
URL: https://github.com/apache/druid/pull/16849#discussion_r1708055566


##########
processing/src/main/java/org/apache/druid/segment/UnnestStorageAdapter.java:
##########
@@ -256,6 +256,23 @@ public Metadata getMetadata()
     return baseAdapter.getMetadata();
   }
 
+  @Override
+  public List<String> getSortOrder()
+  {
+    final List<String> baseSortOrder = baseAdapter.getSortOrder();
+
+    // Sorted the same way as the base segment, unless the unnested column 
shadows one of the base columns.

Review Comment:
   I figure the common case is that the unnested column will not be first in 
the sort order. So we'll return whatever prefix of the order is there up to the 
unnested column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to