github-advanced-security[bot] commented on code in PR #16768: URL: https://github.com/apache/druid/pull/16768#discussion_r1708670622
########## indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionSupervisor.java: ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.compact; + +import org.apache.druid.indexing.overlord.DataSourceMetadata; +import org.apache.druid.indexing.overlord.supervisor.Supervisor; +import org.apache.druid.indexing.overlord.supervisor.SupervisorReport; +import org.apache.druid.indexing.overlord.supervisor.SupervisorStateManager; +import org.apache.druid.indexing.overlord.supervisor.autoscaler.LagStats; +import org.apache.druid.java.util.common.DateTimes; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.server.compaction.CompactionScheduler; +import org.apache.druid.server.coordinator.AutoCompactionSnapshot; + +/** + * Supervisor for compaction of a single datasource. + */ +public class CompactionSupervisor implements Supervisor +{ + private static final Logger log = new Logger(CompactionSupervisor.class); + + private final CompactionScheduler scheduler; + private final CompactionSupervisorSpec supervisorSpec; + + public CompactionSupervisor( + CompactionSupervisorSpec supervisorSpec, + CompactionScheduler scheduler + ) + { + this.supervisorSpec = supervisorSpec; + this.scheduler = scheduler; + } + + @Override + public void start() + { + final String dataSource = getDataSource(); + if (supervisorSpec.isSuspended()) { + log.info("Suspending compaction for dataSource[%s].", dataSource); + scheduler.stopCompaction(dataSource); + } else { + log.info("Starting compaction for dataSource[%s].", dataSource); + scheduler.startCompaction(dataSource, supervisorSpec.getSpec()); + } + } + + @Override + public void stop(boolean stopGracefully) + { + final String dataSource = getDataSource(); + log.info("Stopping compaction for dataSource[%s].", dataSource); + scheduler.stopCompaction(dataSource); + } + + @Override + public SupervisorReport<AutoCompactionSnapshot> getStatus() + { + final AutoCompactionSnapshot snapshot; + if (supervisorSpec.isSuspended()) { + snapshot = AutoCompactionSnapshot.builder(getDataSource()) + .withStatus(AutoCompactionSnapshot.AutoCompactionScheduleStatus.NOT_ENABLED) + .build(); + } else { + snapshot = scheduler.getCompactionSnapshot(getDataSource()); + } + + return new SupervisorReport<>(supervisorSpec.getId(), DateTimes.nowUtc(), snapshot); + } + + @Override + public SupervisorStateManager.State getState() + { + if (!scheduler.isRunning()) { + return State.SCHEDULER_DISABLED; + } else if (supervisorSpec.isSuspended()) { + return State.SUSPENDED; + } else { + return State.RUNNING; + } + } + + private String getDataSource() + { + return supervisorSpec.getSpec().getDataSource(); + } + + // Un-implemented methods used only by streaming supervisors + + @Override + public void reset(DataSourceMetadata dataSourceMetadata) + { + // Do nothing + } + + @Override + public void resetOffsets(DataSourceMetadata resetDataSourceMetadata) + { + // Do nothing + } + + @Override + public void checkpoint(int taskGroupId, DataSourceMetadata checkpointMetadata) + { + // Do nothing + } + + @Override + public LagStats computeLagStats() + { + return new LagStats(0L, 0L, 0L); + } + + @Override + public int getActiveTaskGroupsCount() + { + return 0; + } + + public enum State implements SupervisorStateManager.State Review Comment: ## Class has same name as super class State has the same name as its supertype [org.apache.druid.indexing.overlord.supervisor.SupervisorStateManager$State](1). [Show more details](https://github.com/apache/druid/security/code-scanning/7701) ########## server/src/main/java/org/apache/druid/server/compaction/PriorityBasedSegmentSearchPolicy.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.compaction; + +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.server.coordinator.DataSourceCompactionConfig; +import org.apache.druid.timeline.SegmentTimeline; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +/** + * {@link CompactionSegmentSearchPolicy} that selects segments in order of a + * given priority. + */ +public abstract class PriorityBasedSegmentSearchPolicy implements CompactionSegmentSearchPolicy +{ + private final String priorityDatasource; + + protected PriorityBasedSegmentSearchPolicy( + @Nullable String priorityDatasource + ) + { + this.priorityDatasource = priorityDatasource; + } + + @Nullable + @JsonProperty + public final String getPriorityDatasource() + { + return priorityDatasource; + } + + @Override + public CompactionSegmentIterator createIterator( + Map<String, DataSourceCompactionConfig> compactionConfigs, + Map<String, SegmentTimeline> dataSources, + Map<String, List<Interval>> skipIntervals, + CompactionStatusTracker statusTracker + ) + { + return new PriorityBasedCompactionSegmentIterator( + compactionConfigs, + dataSources, + skipIntervals, + this, + statusTracker + ); + } + + /** + * Checks if compaction of the given candidate segments should be skipped in + * the current iteration. A concrete policy implementation may override this + * method to avoid compacting intervals that do not fulfil some required criteria. + * + * @return false by default + */ + protected boolean shouldSkipCompaction( + SegmentsToCompact candidateSegments, Review Comment: ## Useless parameter The parameter 'candidateSegments' is never used. [Show more details](https://github.com/apache/druid/security/code-scanning/7698) ########## server/src/main/java/org/apache/druid/server/compaction/PriorityBasedSegmentSearchPolicy.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.compaction; + +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.server.coordinator.DataSourceCompactionConfig; +import org.apache.druid.timeline.SegmentTimeline; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +/** + * {@link CompactionSegmentSearchPolicy} that selects segments in order of a + * given priority. + */ +public abstract class PriorityBasedSegmentSearchPolicy implements CompactionSegmentSearchPolicy +{ + private final String priorityDatasource; + + protected PriorityBasedSegmentSearchPolicy( + @Nullable String priorityDatasource + ) + { + this.priorityDatasource = priorityDatasource; + } + + @Nullable + @JsonProperty + public final String getPriorityDatasource() + { + return priorityDatasource; + } + + @Override + public CompactionSegmentIterator createIterator( + Map<String, DataSourceCompactionConfig> compactionConfigs, + Map<String, SegmentTimeline> dataSources, + Map<String, List<Interval>> skipIntervals, + CompactionStatusTracker statusTracker + ) + { + return new PriorityBasedCompactionSegmentIterator( + compactionConfigs, + dataSources, + skipIntervals, + this, + statusTracker + ); + } + + /** + * Checks if compaction of the given candidate segments should be skipped in + * the current iteration. A concrete policy implementation may override this + * method to avoid compacting intervals that do not fulfil some required criteria. + * + * @return false by default + */ + protected boolean shouldSkipCompaction( + SegmentsToCompact candidateSegments, + CompactionStatus currentCompactionStatus, + CompactionTaskStatus latestTaskStatus Review Comment: ## Useless parameter The parameter 'latestTaskStatus' is never used. [Show more details](https://github.com/apache/druid/security/code-scanning/7700) ########## server/src/main/java/org/apache/druid/server/compaction/PriorityBasedSegmentSearchPolicy.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.compaction; + +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.druid.server.coordinator.DataSourceCompactionConfig; +import org.apache.druid.timeline.SegmentTimeline; +import org.joda.time.Interval; + +import javax.annotation.Nullable; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +/** + * {@link CompactionSegmentSearchPolicy} that selects segments in order of a + * given priority. + */ +public abstract class PriorityBasedSegmentSearchPolicy implements CompactionSegmentSearchPolicy +{ + private final String priorityDatasource; + + protected PriorityBasedSegmentSearchPolicy( + @Nullable String priorityDatasource + ) + { + this.priorityDatasource = priorityDatasource; + } + + @Nullable + @JsonProperty + public final String getPriorityDatasource() + { + return priorityDatasource; + } + + @Override + public CompactionSegmentIterator createIterator( + Map<String, DataSourceCompactionConfig> compactionConfigs, + Map<String, SegmentTimeline> dataSources, + Map<String, List<Interval>> skipIntervals, + CompactionStatusTracker statusTracker + ) + { + return new PriorityBasedCompactionSegmentIterator( + compactionConfigs, + dataSources, + skipIntervals, + this, + statusTracker + ); + } + + /** + * Checks if compaction of the given candidate segments should be skipped in + * the current iteration. A concrete policy implementation may override this + * method to avoid compacting intervals that do not fulfil some required criteria. + * + * @return false by default + */ + protected boolean shouldSkipCompaction( + SegmentsToCompact candidateSegments, + CompactionStatus currentCompactionStatus, Review Comment: ## Useless parameter The parameter 'currentCompactionStatus' is never used. [Show more details](https://github.com/apache/druid/security/code-scanning/7699) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
