kfaraz commented on code in PR #16768: URL: https://github.com/apache/druid/pull/16768#discussion_r1728331822
########## indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionScheduler.java: ########## Review Comment: Initially, I had intended to use this interface in `DruidCoordinator` too but that seemed unnecessary. Right now, the purpose of this interface is to hide implementation details in the `OverlordCompactionScheduler` and cleaner guice bindings. It can also be useful for unit testing classes that depend on the `OverlordCompactionScheduler`. Let me know if it seems unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
