sreemanamala commented on code in PR #16885: URL: https://github.com/apache/druid/pull/16885#discussion_r1714638523
########## processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java: ########## Review Comment: The actual problem I tried to fix here is reading from frames. This query works now as deep down it reads rac column from frame bytes. So adding these tests felt irrelevant. This is not just for window functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
