Akshat-Jain commented on code in PR #16885: URL: https://github.com/apache/druid/pull/16885#discussion_r1714641107
########## processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java: ########## Review Comment: Fair enough, but we should certainly have such a test for window functions to ensure it doesn't break in the future. I can add the test as a separate PR once this is merged, I'm okay either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
