Akshat-Jain commented on code in PR #16885:
URL: https://github.com/apache/druid/pull/16885#discussion_r1714634544
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java:
##########
@@ -92,17 +92,18 @@ public Column readRACColumn(Frame frame)
final Memory memory = frame.region(columnNumber);
validate(memory);
- final long positionOfLengths =
getStartOfStringLengthSection(frame.numRows(), false);
- final long positionOfPayloads = getStartOfStringDataSection(memory,
frame.numRows(), false);
+ final boolean multiValue = isMultiValue(memory);
+ final long positionOfLengths =
getStartOfStringLengthSection(frame.numRows(), multiValue);
+ final long positionOfPayloads = getStartOfStringDataSection(memory,
frame.numRows(), multiValue);
StringFrameColumn frameCol =
new StringFrameColumn(
frame,
- false,
+ multiValue,
memory,
positionOfLengths,
positionOfPayloads,
- asArray || isMultiValue(memory) // Read MVDs as String arrays
+ asArray || multiValue // Read MVDs as String arrays
Review Comment:
Is the comment still relevant, or needs an update?
##########
processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java:
##########
Review Comment:
@sreemanamala Thank you for these changes! 🚀
I tried out the following query which was previously giving
`InvalidNullByteException`:
```sql
select countryName, cityName, channel, array_concat_agg(ARRAY['N/A',
countryName], 10000) over (order by countryName) as c
from wikipedia
where countryName in ('Austria', 'Republic of Korea') and (cityName in
('Horsching', 'Vienna', 'Seoul', 'Jeonju') or cityName is null)
group by countryName, cityName, channel
```
The above query seems to work fine with these changes.
Can you please add a similar test in `DrillWindowQueryTest` so that we have
a validation for such queries for both engines? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
