cryptoe commented on code in PR #16890:
URL: https://github.com/apache/druid/pull/16890#discussion_r1721258945


##########
server/src/test/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCacheTest.java:
##########
@@ -2214,6 +2215,77 @@ protected void coldDatasourceSchemaExec()
     Assert.assertEquals(0, latch.getCount());
   }
 
+  @Test
+  public void testTombstoneSegmentIsNotAdded() throws InterruptedException

Review Comment:
   Nit: This test case is very similar to 
BSMC#testTombstoneSegmentIsNotAdded(). Can we do a bit of refactor to remove 
redundancy. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to