findingrish commented on code in PR #16890:
URL: https://github.com/apache/druid/pull/16890#discussion_r1722724633
##########
server/src/test/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCacheTest.java:
##########
@@ -2214,6 +2215,77 @@ protected void coldDatasourceSchemaExec()
Assert.assertEquals(0, latch.getCount());
}
+ @Test
+ public void testTombstoneSegmentIsNotAdded() throws InterruptedException
Review Comment:
The test is trying ensure that tombstone segments are not added to the
Broker and Coordinator cache instances.
Refactoring the test wouldn't be very beneficial since,
- Timeline used in the two caches is different.
-
`org.apache.druid.segment.metadata.AbstractSegmentMetadataCache#getSegmentMetadataSnapshot`
implementation differs between the two instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
