LakshSingla commented on code in PR #16800:
URL: https://github.com/apache/druid/pull/16800#discussion_r1721885451
##########
processing/src/main/java/org/apache/druid/query/operator/WindowOperatorQueryQueryToolChest.java:
##########
@@ -116,6 +128,36 @@ public Sequence<Object[]> resultsAsArrays(
return (Sequence) resultSequence;
}
+ @Override
+ public Optional<Sequence<FrameSignaturePair>> resultsAsFrames(
+ WindowOperatorQuery query,
+ Sequence<RowsAndColumns> resultSequence,
+ MemoryAllocatorFactory memoryAllocatorFactory,
+ boolean useNestedForUnknownTypes
+ )
+ {
Review Comment:
I have added a context parameter
(https://github.com/apache/druid/pull/16800/commits/ea1d57edf617e855bb35ca62d89519467debb797#diff-a31fa1872294019b29fc9940740cd66774a6af7430f8b7f3d4bc95ce3b5d6380R28)
and I wanted a buy-in about its usefulness.
Either
a. "serialization: frames/rows"
or b. "subquery":true, along with `maxSubqueryBytes/maxSubqueryRows`
would be enough to disambiguate between the two ways in which the window
toolchest can return the results.
We'd definitely need to add a flag, and the first one seems self-sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
