LakshSingla commented on code in PR #16800:
URL: https://github.com/apache/druid/pull/16800#discussion_r1750718531
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -840,6 +846,7 @@ private static <T, QueryType extends Query<T>>
Optional<DataSource> materializeR
+ "from the query context and/or the server
config."
);
} else {
+ resultSequence.set(results);
return Optional.empty();
Review Comment:
> as it could catch NullPointerException or AIOOBE and such as well
That won't happen. This is because `startedAccumulating` indicates that the
query processing has began. NullPtrException and AIOOBE will only happen if we
have started processing the subquery results, which would mean that
`startedAccumulating = true`. And if that's the case, for any random
`Exception`, we rethrow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
