kgyrtkirk commented on code in PR #16800:
URL: https://github.com/apache/druid/pull/16800#discussion_r1750787161
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -840,6 +846,7 @@ private static <T, QueryType extends Query<T>>
Optional<DataSource> materializeR
+ "from the query context and/or the server
config."
);
} else {
+ resultSequence.set(results);
return Optional.empty();
Review Comment:
* that boolean is not `true` but will be catched in [this
block](https://github.com/apache/druid/pull/16800/files/350661e41fc6cc5ec2d0a86bf3b46749e54bfc0a#diff-073196043cf52e8c14ca92d8df79bc9e17b20e6df3fb60ec0a97f78b5d896595R783-R795)
* which also contains `toolChest#resultsAsFrames` which has a few
implementations - any of which could throw an `Exception` and will be routed
to a retry.
* isn't a possible problematic case would be if the signature contains a
column starting with `___druid` ; which produces an `IAE`?
* `TimeseriesQQTC#resultsAsFrames` ->
`FrameWriters.makeColumnBasedFrameWriterFactory` ->
`disallowedFieldNames.isEmpty()` -> `IAE` ?
could you please answer my original question:
> why do we want to fallback - instead of telling the user that this have
failed; and he might want to try the row based limiting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
