gianm commented on PR #16849: URL: https://github.com/apache/druid/pull/16849#issuecomment-2298211708
Pushed up a commit resolving conflicts with #16533. Main changes: - Changed frame cursors to report "no ordering" rather than time ordering. - Removed `descending` from `Joinable#makeJoinMatcher`. Now that `descending` has more or less been phased out in favor of `ordering: [__time DESC]`, the joinable order no longer needs to be reversed. (All joined rows arising from the same left-hand row have the same value.) - Moved getMinTime, getMaxTime, and getMaxIngestedEventTime from StorageAdapter to TimeBoundaryInspector and MaxIngestedEventTimeInspector. This is mainly necessary for timeBoundary queries to be able to tell whether they can use getMinTime and getMaxTime, vs. needing to use a cursor. Previously, timeBoundary assumed that an adapter backing a TableDataSource was guaranteed to have an exact getMinTime and getMaxTime. But after this patch, that isn't necessarily going to be the case (in particular: a non-time-sorted segment won't be able to know its exact min/max time without a full scan.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
