github-advanced-security[bot] commented on code in PR #16849:
URL: https://github.com/apache/druid/pull/16849#discussion_r1722769440


##########
processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinMatcher.java:
##########
@@ -133,7 +127,7 @@
       );
     }
 
-    ColumnSelectorFactory selectorFactory = 
table.makeColumnSelectorFactory(joinableOffset, descending, closer);
+    ColumnSelectorFactory selectorFactory = 
table.makeColumnSelectorFactory(joinableOffset, closer);

Review Comment:
   ## Possible confusion of local and field
   
   Potentially confusing name: [IndexedTableJoinMatcher](1) also refers to 
field [selectorFactory](2) (as this.selectorFactory).
   
   [Show more 
details](https://github.com/apache/druid/security/code-scanning/7734)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to