cryptoe commented on code in PR #17027:
URL: https://github.com/apache/druid/pull/17027#discussion_r1753165605
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -374,4 +375,10 @@ public LookupLoadingSpec getLookupLoadingSpec()
{
return LookupLoadingSpec.NONE;
}
+
+ @Override
+ public BroadcastDatasourceLoadingSpec getBroadcastDatasourceLoadingSpec()
+ {
+ return BroadcastDatasourceLoadingSpec.NONE;
Review Comment:
Which tasktypes would have a difference in LookupLoadingSpec and Broadcast
loading spec?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java:
##########
@@ -184,6 +186,7 @@ default Set<ResourceAction> getInputSourceResources()
throws UOE
* MSQWorkerTask returns true from this method (because it embeds a query
stack for running multi-stage queries)
* even though it is not directly queryable via HTTP.
*/
+ @Deprecated
Review Comment:
We adjust merge pools and stuff with this method. Why is this marked
deprecated. The javadocs below fail to shed light on this.
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentBootstrapper.java:
##########
@@ -261,9 +267,16 @@ private void loadSegmentsOnStartup() throws IOException
/**
* @return a list of bootstrap segments. When bootstrap segments cannot be
found, an empty list is returned.
+ * The bootstrap segments returned are filtered by the broadcast datasources
indicated by {@link DataSourceTaskIdHolder#getBroadcastDatasourceLoadingSpec()}
+ * if applicable.
*/
private List<DataSegment> getBootstrapSegments()
{
+ final BroadcastDatasourceLoadingSpec.Mode mode =
datasourceHolder.getBroadcastDatasourceLoadingSpec().getMode();
Review Comment:
Can we use datasourceHolder.getLookupLoadingSpec() here and not add any new
configs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
