abhishekrb19 commented on code in PR #17027:
URL: https://github.com/apache/druid/pull/17027#discussion_r1755985664
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -374,4 +375,10 @@ public LookupLoadingSpec getLookupLoadingSpec()
{
return LookupLoadingSpec.NONE;
}
+
+ @Override
+ public BroadcastDatasourceLoadingSpec getBroadcastDatasourceLoadingSpec()
+ {
+ return BroadcastDatasourceLoadingSpec.NONE;
Review Comment:
yeah, thinking about this, the `LookingLoadingSpec` is used in the
[Task](https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java#L333)
interface, so it's not trivial to rename and merge the functionalities.
Although, I think there's some scope to extract some common things like `Mode`
to a static class that can be shared between `LookingLoadingSpec` and
`BroadcastDatasourceLoadingSpec`. I can handle that in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
