abhishekrb19 commented on code in PR #17027:
URL: https://github.com/apache/druid/pull/17027#discussion_r1754320158
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -374,4 +375,10 @@ public LookupLoadingSpec getLookupLoadingSpec()
{
return LookupLoadingSpec.NONE;
}
+
+ @Override
+ public BroadcastDatasourceLoadingSpec getBroadcastDatasourceLoadingSpec()
+ {
+ return BroadcastDatasourceLoadingSpec.NONE;
Review Comment:
For broadcast datasources, we'd also have to find the set of broadcast
datasources specified in the sql query through the schema. Since the set of
lookups and set of broadcast datasources can be different, it'd make sense to
have different loading specs, and not reuse `LookupLoadingSpec`.
So for compaction tasks, the `BroadcastDatasourceLoadingSpec` can be
different from `LookupLoadingSpec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
