kgyrtkirk commented on code in PR #17036:
URL: https://github.com/apache/druid/pull/17036#discussion_r1756143992
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQWindowTest.java:
##########
@@ -2323,4 +2326,23 @@ public void
testReplaceWithPartitionedByDayOnWikipedia(String contextName, Map<S
)))
.verifyResults();
}
+
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
Review Comment:
what's the point of parameterizing this test? do those parameter changes
relevant for this test?
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -451,6 +453,14 @@ private boolean comparePartitionKeys(ResultRow row1,
ResultRow row2, List<String
int match = 0;
for (String columnName : partitionColumnNames) {
int i = frameReader.signature().indexOf(columnName);
+ if
(ColumnType.STRING.equals(frameReader.signature().getColumnType(columnName).get())
&& (row1.get(i) instanceof List || row2.get(i) instanceof List)) {
Review Comment:
this is an unfortunate place to add this check - and it would only care
about partition columns
I think the other check which was added in #17002 should get triggered...
...and actually it would if there wouldn't be a `compare` in this
class....this conditional will go away along with this whole method soon; so
doesn't matter - its ok to have it like this until we get to that point....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
