Akshat-Jain commented on code in PR #17036:
URL: https://github.com/apache/druid/pull/17036#discussion_r1768098463


##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQWindowTest.java:
##########
@@ -2323,4 +2326,43 @@
                      )))
                      .verifyResults();
   }
+
+  @MethodSource("data")
+  @ParameterizedTest(name = "{index}:with context {0}")
+  public void testFailurePartitionByMVD_1(String contextName, Map<String, 
Object> context)

Review Comment:
   I was trying to keep it consistent with the rest of the file. I don't know 
why it was parameterized from the beginning, maybe it was just kept that way to 
allow flexibility to extend it in the future if needed.
   
   Have made all tests of MSQWindowTest non-parameterized. Hope that works.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to