Akshat-Jain commented on code in PR #17036:
URL: https://github.com/apache/druid/pull/17036#discussion_r1756160696
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -451,6 +453,14 @@ private boolean comparePartitionKeys(ResultRow row1,
ResultRow row2, List<String
int match = 0;
for (String columnName : partitionColumnNames) {
int i = frameReader.signature().indexOf(columnName);
+ if
(ColumnType.STRING.equals(frameReader.signature().getColumnType(columnName).get())
&& (row1.get(i) instanceof List || row2.get(i) instanceof List)) {
Review Comment:
@kgyrtkirk Yeah I agree. We can keep it as it is until we get
GlueingPartitioningOperator (I manually verified the MVD queries on my local
branch with the GlueingPartitioningOperator changes, all of them error out
properly).
The check in this PR isn't exhaustive, but it atleast works for some kind of
queries. Not sure if that's preferable though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
