kgyrtkirk commented on code in PR #16658:
URL: https://github.com/apache/druid/pull/16658#discussion_r1760610529
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/concrete/FrameRowsAndColumns.java:
##########
@@ -17,21 +17,24 @@
* under the License.
*/
-package org.apache.druid.query.rowsandcols.semantic;
+package org.apache.druid.query.rowsandcols.concrete;
-import org.apache.druid.java.util.common.ISE;
+import org.apache.druid.frame.Frame;
import org.apache.druid.query.rowsandcols.RowsAndColumns;
+import org.apache.druid.segment.column.RowSignature;
-public interface WireTransferable
+import javax.annotation.Nullable;
+
+public interface FrameRowsAndColumns extends RowsAndColumns
{
- static WireTransferable fromRAC(RowsAndColumns rac)
+ Frame getFrame();
+
+ RowSignature getSignature();
+
+ @Nullable
+ @Override
+ default <T> T as(Class<T> clazz)
{
- WireTransferable retVal = rac.as(WireTransferable.class);
- if (retVal == null) {
- throw new ISE("Rac[%s] cannot be transferred over the wire",
rac.getClass());
- }
- return retVal;
+ return RowsAndColumns.super.as(clazz);
Review Comment:
nit: is it needed to define this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
