sreemanamala commented on code in PR #16658:
URL: https://github.com/apache/druid/pull/16658#discussion_r1749584582
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/LazilyDecoratedRowsAndColumns.java:
##########
@@ -150,16 +150,13 @@ public RowsAndColumnsDecorator toRowsAndColumnsDecorator()
@SuppressWarnings("unused")
@SemanticCreator
- public WireTransferable toWireTransferable()
+ public FrameRowsAndColumns toFrameRowsAndColumns()
{
- return () -> {
- final Pair<byte[], RowSignature> materialized = materialize();
- if (materialized == null) {
- return new byte[]{};
- } else {
- return materialized.lhs;
- }
- };
+ maybeMaterialize();
+ if (base instanceof FrameRowsAndColumns) {
+ return (FrameRowsAndColumns) base;
+ }
+ return null;
Review Comment:
thinking of updating this to `return base.as(FrameRowsAndColumns.class)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
