sreemanamala commented on code in PR #16658:
URL: https://github.com/apache/druid/pull/16658#discussion_r1753305665
##########
processing/src/test/java/org/apache/druid/common/semantic/SemanticCreatorUsageTest.java:
##########
@@ -87,8 +87,8 @@ public void testReturnType()
{
Class<?> returnType = method.getReturnType();
assertTrue(
- returnType + " is not an interface; this method must return with an
interface; ",
- returnType.isInterface()
+ returnType + " is not an interface or abstract class; this method must
return with either of them; ",
+ returnType.isInterface() ||
Modifier.isAbstract(returnType.getModifiers())
Review Comment:
I guess that would be more cleaner. Will update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
