Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1761136917
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -213,7 +213,8 @@ Current approach with R&C and operators materialize a
single R&C for processing.
Most of the window operations like SUM(), RANK(), RANGE() etc. can be
made with 2 passes of the data. We might think to reimplement them in the MSQ
way so that we do not have to materialize so much data.
*/
- if (partitionColumnNames.isEmpty()) {
+ // todo: need to cleanup unused code and comments
+ if (true) {
Review Comment:
Based on further offline discussion, the plan for now is to replace
NaivePartitioningOperatorFactory with GlueingPartitioningOperatorFactory in
WindowOperatorQueryKit layer, as that layer has access to everything
(maxRowsMaterialized and corresponding MSQ constants). Will work on making this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
