Akshat-Jain commented on code in PR #17038:
URL: https://github.com/apache/druid/pull/17038#discussion_r1773628796
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -280,12 +289,21 @@ private static List<OperatorFactory>
computeWindowOperations(
if (!sortMatches(priorSortColumns, sortColumns)) {
// Sort order needs to change. Resort and repartition.
ops.add(new NaiveSortOperatorFactory(new ArrayList<>(sortColumns)));
- ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ if (sqlEngine instanceof NativeSqlEngine) {
+ ops.add(new
NaivePartitioningOperatorFactory(group.getPartitionColumns()));
+ } else {
+ ops.add(new
GlueingPartitioningOperatorFactory(group.getPartitionColumns()));
+ }
Review Comment:
This comment is not relevant anymore with the latest changes on the PR,
hence closing it.
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -248,7 +256,8 @@ public static Windowing fromCalciteStuff(
private static List<OperatorFactory> computeWindowOperations(
final PartialDruidQuery partialQuery,
final RowSignature sourceRowSignature,
- List<WindowComputationProcessor> windowGroupProcessors
+ List<WindowComputationProcessor> windowGroupProcessors,
+ SqlEngine sqlEngine
Review Comment:
This comment is not relevant anymore with the latest changes on the PR,
hence closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
