nozjkoitop commented on code in PR #16889: URL: https://github.com/apache/druid/pull/16889#discussion_r1777221795
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/WorkerTaskRunnerConfig.java: ########## @@ -29,14 +34,17 @@ public class WorkerTaskRunnerConfig @JsonProperty private double parallelIndexTaskSlotRatio = 1; + @JsonProperty + private Map<String, @Min(value = 0, message = "Task slot ratio for must be at least 0.") @Max(value = 1, message = "Task slot ratio cannot be greater than 1") Double> taskSlotRatiosPerWorker = new HashMap<>(); Review Comment: I'm not sure if adding the constructor would be the best solution here as this is the parent for a couple other classes, and it will require children refactoring as well (including default values specifying), min max annotations seems to be a better approach, if it'll go together with JsonConfigurator update, otherwise I'd better stick with CustomDeserializer validation approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
