nozjkoitop commented on code in PR #16889:
URL: https://github.com/apache/druid/pull/16889#discussion_r1778143381
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/ImmutableWorkerInfoTest.java:
##########
@@ -225,11 +239,14 @@ public void test_canRunTask()
new Worker("http", "testWorker2", "192.0.0.1", 10, "v1",
WorkerConfig.DEFAULT_CATEGORY),
6,
0,
+ Collections.emptyMap(),
ImmutableSet.of("grp1", "grp2"),
ImmutableSet.of("task1", "task2"),
DateTimes.of("2015-01-01T01:01:02Z")
);
+ WorkerTaskRunnerConfig config = mock(WorkerTaskRunnerConfig.class);
Review Comment:
This will require changing the config class as currently we don't have
setters or constructors (except NoArgs) To use actual config object the most
painless approach is to add setters and mark them as VisibleForTesting, @kfaraz
WDYT?
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/ImmutableWorkerInfoTest.java:
##########
@@ -225,11 +239,14 @@ public void test_canRunTask()
new Worker("http", "testWorker2", "192.0.0.1", 10, "v1",
WorkerConfig.DEFAULT_CATEGORY),
6,
0,
+ Collections.emptyMap(),
ImmutableSet.of("grp1", "grp2"),
ImmutableSet.of("task1", "task2"),
DateTimes.of("2015-01-01T01:01:02Z")
);
+ WorkerTaskRunnerConfig config = mock(WorkerTaskRunnerConfig.class);
Review Comment:
This will require changing the config class as currently we don't have
setters or constructors (except NoArgs). To use actual config object the most
painless approach is to add setters and mark them as VisibleForTesting, @kfaraz
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
