kfaraz commented on code in PR #16889: URL: https://github.com/apache/druid/pull/16889#discussion_r1777281621
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/WorkerTaskRunnerConfig.java: ########## @@ -29,14 +34,17 @@ public class WorkerTaskRunnerConfig @JsonProperty private double parallelIndexTaskSlotRatio = 1; + @JsonProperty + private Map<String, @Min(value = 0, message = "Task slot ratio for must be at least 0.") @Max(value = 1, message = "Task slot ratio cannot be greater than 1") Double> taskSlotRatiosPerWorker = new HashMap<>(); Review Comment: Hmm, fair point. In that case, let's just skip the validation altogether as there is no validation currently happening for `parallelIndexTaskSlotRatio` either. We can add it when needed later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
