adarshsanjeev commented on code in PR #17405:
URL: https://github.com/apache/druid/pull/17405#discussion_r1816332107
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessorFactory.java:
##########
@@ -56,26 +56,26 @@
@JsonTypeName("window")
public class WindowOperatorQueryFrameProcessorFactory extends
BaseFrameProcessorFactory
{
- private final WindowOperatorQuery query;
+ private final QueryContext queryContext;
private final List<OperatorFactory> operatorList;
private final RowSignature stageRowSignature;
@JsonCreator
public WindowOperatorQueryFrameProcessorFactory(
- @JsonProperty("query") WindowOperatorQuery query,
+ @JsonProperty("queryContext") QueryContext queryContext,
@JsonProperty("operatorList") List<OperatorFactory> operatorFactoryList,
@JsonProperty("stageRowSignature") RowSignature stageRowSignature
)
{
- this.query = Preconditions.checkNotNull(query, "query");
+ this.queryContext = Preconditions.checkNotNull(queryContext, "query");
this.operatorList = Preconditions.checkNotNull(operatorFactoryList, "bad
operator");
this.stageRowSignature = Preconditions.checkNotNull(stageRowSignature,
"stageSignature");
}
- @JsonProperty("query")
- public WindowOperatorQuery getQuery()
+ @JsonProperty("queryContext")
Review Comment:
The controller does not need to be on the same middle manager as the worker.
There can be two different middle managers versions in a cluster at a time.
I don't think there is a backward compatible way to remove query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
