Akshat-Jain commented on code in PR #17405:
URL: https://github.com/apache/druid/pull/17405#discussion_r1816354962
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessorFactory.java:
##########
@@ -56,26 +56,26 @@
@JsonTypeName("window")
public class WindowOperatorQueryFrameProcessorFactory extends
BaseFrameProcessorFactory
{
- private final WindowOperatorQuery query;
+ private final QueryContext queryContext;
private final List<OperatorFactory> operatorList;
private final RowSignature stageRowSignature;
@JsonCreator
public WindowOperatorQueryFrameProcessorFactory(
- @JsonProperty("query") WindowOperatorQuery query,
+ @JsonProperty("queryContext") QueryContext queryContext,
@JsonProperty("operatorList") List<OperatorFactory> operatorFactoryList,
@JsonProperty("stageRowSignature") RowSignature stageRowSignature
)
{
- this.query = Preconditions.checkNotNull(query, "query");
+ this.queryContext = Preconditions.checkNotNull(queryContext, "query");
this.operatorList = Preconditions.checkNotNull(operatorFactoryList, "bad
operator");
this.stageRowSignature = Preconditions.checkNotNull(stageRowSignature,
"stageSignature");
}
- @JsonProperty("query")
- public WindowOperatorQuery getQuery()
+ @JsonProperty("queryContext")
Review Comment:
> This would cause MSQ queries with window functions to fail, I'm not sure
if we are okay with breaking changes to window functions or its fine since it
is still experimental.
Window functions are going to be GA as part of Druid 31 release.
> I don't think there is a backward compatible way to remove query
Yeah..
How do we generally make any changes to any other processor factory classes
while ensuring backward compatibility? It doesn't seem like a trivial thing to
achieve while ensuring clean code.
Is this something we can put in the release notes section? I think it's
better to break backward compatibility sooner than later, if it's inevitable.
Thoughts? cc: @kgyrtkirk @cryptoe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
