Akshat-Jain commented on code in PR #17377:
URL: https://github.com/apache/druid/pull/17377#discussion_r1818373338
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteMSQTestsHelper.java:
##########
@@ -416,6 +416,9 @@ protected static Supplier<ResourceHolder<CompleteSegment>>
getSupplierForSegment
case CalciteTests.T_ALL_TYPE_PARQUET:
index =
TestDataBuilder.getQueryableIndexForDrillDatasource(segmentId.getDataSource(),
tempFolderProducer.apply("tmpDir"));
break;
+ case CalciteTests.BENCHMARK_DATASOURCE:
Review Comment:
> Is there scope in reusing this datasource for anything else? If so, it
could be renamed to a more general name.
No, there isn't any scope in re-using this for anything else.
> If not, I'm wondering if there is a better way to override this just for
the one test.
I'm not sure if that's doable, it's not trivial to achieve atleast.
With that said, we did it in a similar way when we added datasources for
drill test suite (the `case` statements just above the added line of code) - so
if we really want to, I feel it could be a follow-up patch for both drill and
benchmark datasources. But I also think it doesn't add any value to
over-engineer this, since this change doesn't affect any other test. Hope that
makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
