Akshat-Jain commented on code in PR #17377:
URL: https://github.com/apache/druid/pull/17377#discussion_r1820079453
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryTestRunner.java:
##########
@@ -772,8 +772,11 @@ public void run()
public QueryResults resultsOnly()
{
- ExecuteQuery execStep = (ExecuteQuery) runSteps.get(0);
- execStep.run();
+ for (QueryRunStep runStep : runSteps) {
+ runStep.run();
+ }
+
+ BaseExecuteQuery execStep = (BaseExecuteQuery)
runSteps.get(runSteps.size() - 1);
Review Comment:
`queryTestBuilder.results()` didn't support MSQ apparently, since it only
had the execute step, and not the ExtractResultsFactory step.
So, without this change, instead of getting the query results, we were
getting the query ID. The ExtractResultsFactory step (added as a custom runner
when declaring QueryTestBuilder) takes the query ID, and contacts the overlord
client, and fetches the actual results.
> (and not others)?
In the regular MSQ tests, we do `testBuilder().run()` which handled both
steps already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
