adarshsanjeev commented on code in PR #17377:
URL: https://github.com/apache/druid/pull/17377#discussion_r1820065415
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryTestRunner.java:
##########
@@ -772,8 +772,11 @@ public void run()
public QueryResults resultsOnly()
{
- ExecuteQuery execStep = (ExecuteQuery) runSteps.get(0);
- execStep.run();
+ for (QueryRunStep runStep : runSteps) {
+ runStep.run();
+ }
+
+ BaseExecuteQuery execStep = (BaseExecuteQuery)
runSteps.get(runSteps.size() - 1);
Review Comment:
I'm not very familiar with this, why is the change required to run all
runsteps for this benchmark (and not others)?
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteMSQTestsHelper.java:
##########
@@ -416,6 +416,9 @@ protected static Supplier<ResourceHolder<CompleteSegment>>
getSupplierForSegment
case CalciteTests.T_ALL_TYPE_PARQUET:
index =
TestDataBuilder.getQueryableIndexForDrillDatasource(segmentId.getDataSource(),
tempFolderProducer.apply("tmpDir"));
break;
+ case CalciteTests.BENCHMARK_DATASOURCE:
Review Comment:
It does look a bit strange to have details of a datasource used by a single
test here. This class would probably explode in size if this was the case for
more tests. We can refactor it in a followup though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
