LakshSingla commented on code in PR #17360:
URL: https://github.com/apache/druid/pull/17360#discussion_r1830324199
##########
server/src/main/java/org/apache/druid/server/metrics/QueryCountStatsMonitor.java:
##########
@@ -72,9 +75,11 @@ public boolean doMonitor(ServiceEmitter emitter)
}
}
- long pendingQueries = this.mergeBufferPool.getPendingRequests();
- emitter.emit(builder.setMetric("mergeBuffer/pendingRequests",
pendingQueries));
+ if (emitMergeBufferPendingRequests) {
+ long pendingQueries = this.mergeBufferPool.getPendingRequests();
+ emitter.emit(builder.setMetric("mergeBuffer/pendingRequests",
pendingQueries));
+ }
+
Review Comment:
But we don't have any plans of removing this code right? Which makes me
wonder if the additional complexity is worth it. The situation is that we have
had a metric in past, which was emitted without a monitor, and we are not
planning on modifying the behavior (LMK if this part is not true, which will
make the comment null & void). So it doesn't seem correct that we are emitting
this from the monitor as well for correctness given that we also have weird
artefacts of this metric in QueryCountStatsMonitor which would not be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
