findingrish commented on code in PR #17360:
URL: https://github.com/apache/druid/pull/17360#discussion_r1830822244
##########
server/src/main/java/org/apache/druid/server/metrics/QueryCountStatsMonitor.java:
##########
@@ -72,9 +75,11 @@ public boolean doMonitor(ServiceEmitter emitter)
}
}
- long pendingQueries = this.mergeBufferPool.getPendingRequests();
- emitter.emit(builder.setMetric("mergeBuffer/pendingRequests",
pendingQueries));
+ if (emitMergeBufferPendingRequests) {
+ long pendingQueries = this.mergeBufferPool.getPendingRequests();
+ emitter.emit(builder.setMetric("mergeBuffer/pendingRequests",
pendingQueries));
+ }
+
Review Comment:
> The situation is that we have had a metric in past, which was emitted
without a monitor, and we are not planning on modifying the behavior
This isn't right, the metric was emitted from a monitor earlier
(QueryCountStatsMonitor.java).
We can remove the metric from the old monitor and the corresponding code in
the next release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
