kgyrtkirk commented on code in PR #17466:
URL: https://github.com/apache/druid/pull/17466#discussion_r1846700300
##########
pom.xml:
##########
@@ -271,6 +272,16 @@
<enabled>false</enabled>
</snapshots>
</repository>
+
+ <!--
+ maven-dependency-plugin:3.1.2 seems to have updated HTTP repository
access behavior.
Review Comment:
error was in `druid-thrift-extensions`:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:go-offline (default-cli)
on project druid-thrift-extensions:
org.eclipse.aether.resolution.DependencyResolutionException: Failed to collect
dependencies at com.twitter.elephantbird:elephant-bird-core:jar:4.17 ->
com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19: Failed to read artifact
descriptor for com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19: Could not
transfer artifact com.hadoop.gplcompression:hadoop-lzo:pom:0.4.19 from/to
maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories:
[twitter (http://maven.twttr.com, default, releases+snapshots)] -> [Help 1]
```
* this seems to be deliberately excluded from the pom
[here](https://github.com/apache/druid/blob/24a1fafaa745fb93bf1522490c095cd689fd9996/extensions-contrib/thrift-extensions/pom.xml#L83-L86)
* and its documented to download it separately
[here](https://github.com/apache/druid/blob/master/docs/development/extensions-contrib/thrift.md#lzo-support)
* at the same these artifacts are 10+ year old
[ones](https://mvnrepository.com/artifact/com.hadoop.gplcompression)...I don't
think we want them in the base build
I'm not sure why `go-offline` still want to read that excluded
artifact...and how it did that before...
but instead of adding this repo to the main pom; can we only add it for the
`extensions-contrib/thrift-extensions` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
